Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2510683002:
Overload << operator to allow logging of AccountIds. (Closed)
|
Created:
4 years, 1 month ago by Thiemo Nagel Modified:
3 years, 6 months ago Reviewers:
msarda CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOverload << operator to allow logging of AccountIds.
BUG=none
Review-Url: https://codereview.chromium.org/2510683002
Cr-Commit-Position: refs/heads/master@{#477647}
Committed: https://chromium.googlesource.com/chromium/src/+/659a5c9a6c0e44bf03029199a448d5445a70910a
Patch Set 1 #Patch Set 2 : Add type #
Messages
Total messages: 28 (15 generated)
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tnagel@chromium.org changed reviewers: + atwilson@chromium.org
Hi Drew, could you please take a look? Thank you, Thiemo
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Friendly ping. https://memegen.googleplex.com/5050982249005056
Drew, could you maybe take a look at this small CL?
tnagel@chromium.org changed reviewers: + msarda@chromium.org - atwilson@chromium.org
Hi Mihai, now that you've pulled my previous reviewer from the OWNERS file, could you maybe take a look? Thank you, Thiemo
lgtm
On 2016/12/23 15:04:52, msarda wrote: > lgtm Thank you! Thiemo
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hey Mihai, could you please take another look? I've rebased and added printing of the type and the tests pass now. Thank you and kind regards, Thiemo
lgtm
The CQ bit was checked by tnagel@chromium.org
On 2017/06/07 13:14:57, msarda wrote: > lgtm Thank you!
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496844515108020,
"parent_rev": "c934896452fd0d3e518d1ffe77f68e0a25e66b34", "commit_rev":
"659a5c9a6c0e44bf03029199a448d5445a70910a"}
Message was sent while issue was closed.
Description was changed from ========== Overload << operator to allow logging of AccountIds. BUG=none ========== to ========== Overload << operator to allow logging of AccountIds. BUG=none Review-Url: https://codereview.chromium.org/2510683002 Cr-Commit-Position: refs/heads/master@{#477647} Committed: https://chromium.googlesource.com/chromium/src/+/659a5c9a6c0e44bf03029199a448... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/659a5c9a6c0e44bf03029199a448... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
