Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2510653002: [ic] Pass name to LoadGlobalIC again. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Pass name to LoadGlobalIC again. The reasons are: 1) The names dictionaries in the feedback metadata seems to consume a lot of memory and the idea didn't payoff. 2) The absence of a name parameter blocks data handlers support in LoadGlobalIC. This CL reverts a part of r37278 (https://codereview.chromium.org/2096653003/). BUG=chromium:576312, v8:5561 Committed: https://crrev.com/d3231f5144d4d2b792e54055ba17fbbb347caa55 Cr-Commit-Position: refs/heads/master@{#41046}

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Release fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -97 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 chunks +16 lines, -8 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/interface-descriptors.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/interface-descriptors.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 4 chunks +13 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallGlobal.golden View 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 5 chunks +9 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalCompoundExpressions.golden View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalCountOperators.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalDelete.golden View 2 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden View 5 chunks +12 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Typeof.golden View 1 chunk +3 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-pipeline-unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Igor Sheludko
Ross, PTAL interpreter Jakob, PTAL the rest
4 years, 1 month ago (2016-11-16 11:49:10 UTC) #6
rmcilroy
interpreter/ LGTM.
4 years, 1 month ago (2016-11-16 12:52:53 UTC) #9
Jakob Kummerow
LGTM % rebasing. You'll also need src/compiler/OWNERS review.
4 years, 1 month ago (2016-11-16 13:54:25 UTC) #10
Benedikt Meurer
LGTM on compiler.
4 years, 1 month ago (2016-11-16 14:00:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510653002/40001
4 years, 1 month ago (2016-11-16 17:37:25 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/28055) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-16 17:40:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510653002/60001
4 years, 1 month ago (2016-11-16 17:47:34 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-16 18:17:30 UTC) #22
Benedikt Meurer
For the record, this tanks SunSpider by ~2% w/ Ignition+TurboFan. I guess that's an indicator ...
4 years, 1 month ago (2016-11-17 04:38:54 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:51 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d3231f5144d4d2b792e54055ba17fbbb347caa55
Cr-Commit-Position: refs/heads/master@{#41046}

Powered by Google App Engine
This is Rietveld 408576698