Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/interpreter/bytecode-generator.cc

Issue 2510653002: [ic] Pass name to LoadGlobalIC again. (Closed)
Patch Set: Release fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-generator.h" 5 #include "src/interpreter/bytecode-generator.h"
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-info.h" 10 #include "src/compilation-info.h"
(...skipping 1801 matching lines...) Expand 10 before | Expand all | Expand 10 after
1812 // We need to load the variable into the accumulator, even when in a 1812 // We need to load the variable into the accumulator, even when in a
1813 // VisitForRegisterScope, in order to avoid register aliasing if 1813 // VisitForRegisterScope, in order to avoid register aliasing if
1814 // subsequent expressions assign to the same variable. 1814 // subsequent expressions assign to the same variable.
1815 builder()->LoadAccumulatorWithRegister(source); 1815 builder()->LoadAccumulatorWithRegister(source);
1816 if (hole_check_mode == HoleCheckMode::kRequired) { 1816 if (hole_check_mode == HoleCheckMode::kRequired) {
1817 BuildThrowIfHole(variable->name()); 1817 BuildThrowIfHole(variable->name());
1818 } 1818 }
1819 break; 1819 break;
1820 } 1820 }
1821 case VariableLocation::UNALLOCATED: { 1821 case VariableLocation::UNALLOCATED: {
1822 builder()->LoadGlobal(feedback_index(slot), typeof_mode); 1822 builder()->LoadGlobal(variable->name(), feedback_index(slot),
1823 typeof_mode);
1823 break; 1824 break;
1824 } 1825 }
1825 case VariableLocation::CONTEXT: { 1826 case VariableLocation::CONTEXT: {
1826 int depth = execution_context()->ContextChainDepth(variable->scope()); 1827 int depth = execution_context()->ContextChainDepth(variable->scope());
1827 ContextScope* context = execution_context()->Previous(depth); 1828 ContextScope* context = execution_context()->Previous(depth);
1828 Register context_reg; 1829 Register context_reg;
1829 if (context) { 1830 if (context) {
1830 context_reg = context->reg(); 1831 context_reg = context->reg();
1831 depth = 0; 1832 depth = 0;
1832 } else { 1833 } else {
(...skipping 1352 matching lines...) Expand 10 before | Expand all | Expand 10 after
3185 } 3186 }
3186 3187
3187 Runtime::FunctionId BytecodeGenerator::StoreKeyedToSuperRuntimeId() { 3188 Runtime::FunctionId BytecodeGenerator::StoreKeyedToSuperRuntimeId() {
3188 return is_strict(language_mode()) ? Runtime::kStoreKeyedToSuper_Strict 3189 return is_strict(language_mode()) ? Runtime::kStoreKeyedToSuper_Strict
3189 : Runtime::kStoreKeyedToSuper_Sloppy; 3190 : Runtime::kStoreKeyedToSuper_Sloppy;
3190 } 3191 }
3191 3192
3192 } // namespace interpreter 3193 } // namespace interpreter
3193 } // namespace internal 3194 } // namespace internal
3194 } // namespace v8 3195 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698