Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2510633005: Disable the test ChromeSitePerProcessPDFTest.EmbeddedPDFInsideCrossOriginFrame on Windows. (Closed)

Created:
4 years, 1 month ago by EhsanK
Modified:
4 years, 1 month ago
Reviewers:
alexmos
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the test ChromeSitePerProcessPDFTest.EmbeddedPDFInsideCrossOriginFrame on Windows. The test is flaky on Windows 7 build bots. BUG=666379 Committed: https://crrev.com/d9865127cc0dbd5ccab9bc53541cebd7f3b70e84 Cr-Commit-Position: refs/heads/master@{#432934}

Patch Set 1 #

Patch Set 2 : Fixed a comment #

Patch Set 3 : #end --> #endif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 2 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
EhsanK
PTAL.
4 years, 1 month ago (2016-11-17 18:13:18 UTC) #3
alexmos
LGTM
4 years, 1 month ago (2016-11-17 18:15:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510633005/40001
4 years, 1 month ago (2016-11-17 18:40:53 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 19:42:00 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:46 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9865127cc0dbd5ccab9bc53541cebd7f3b70e84
Cr-Commit-Position: refs/heads/master@{#432934}

Powered by Google App Engine
This is Rietveld 408576698