Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/browser/chrome_site_per_process_browsertest.cc

Issue 2510633005: Disable the test ChromeSitePerProcessPDFTest.EmbeddedPDFInsideCrossOriginFrame on Windows. (Closed)
Patch Set: #end --> #endif Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_site_per_process_browsertest.cc
diff --git a/chrome/browser/chrome_site_per_process_browsertest.cc b/chrome/browser/chrome_site_per_process_browsertest.cc
index ccadca9650b8c4e0fd1fd595be0ee43ca0cffeee..788eb657d69eaae9da460526a4825f8bf4612d8e 100644
--- a/chrome/browser/chrome_site_per_process_browsertest.cc
+++ b/chrome/browser/chrome_site_per_process_browsertest.cc
@@ -320,10 +320,19 @@ class ChromeSitePerProcessPDFTest : public ChromeSitePerProcessTest {
DISALLOW_COPY_AND_ASSIGN(ChromeSitePerProcessPDFTest);
};
+// TODO(ekaramad): This test is flaky on Windows 7. Enable it when the issue is
+// fixed ((https://crbug.com/666379).
+#if defined(OS_WIN)
+#define MAYBE_EmbeddedPDFInsideCrossOriginFrame \
+ DISABLED_EmbeddedPDFInsideCrossOriginFrame
+#else
+#define MAYBE_EmbeddedPDFInsideCrossOriginFrame \
+ EmbeddedPDFInsideCrossOriginFrame
+#endif
// This test verifies that when navigating an OOPIF to a page with <embed>-ed
// PDF, the guest is properly created (https://crbug.com/649856).
IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessPDFTest,
- EmbeddedPDFInsideCrossOriginFrame) {
+ MAYBE_EmbeddedPDFInsideCrossOriginFrame) {
// Navigate to a page with an <iframe>.
GURL main_url(embedded_test_server()->GetURL("a.com", "/iframe.html"));
ui_test_utils::NavigateToURL(browser(), main_url);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698