Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2510633002: [api] deprecate v8::Function::IsBuiltin. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] deprecate v8::Function::IsBuiltin. R=jochen@chromium.org, kozyatinskiy@chromium.org Committed: https://crrev.com/0d258b35c8698d5be5f01f3fb5693ac5b42efb27 Cr-Commit-Position: refs/heads/master@{#41060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
This has been introduced in https://codereview.chromium.org/27701002, but from what I can tell, this is no ...
4 years, 1 month ago (2016-11-16 09:24:36 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-17 01:57:25 UTC) #2
kozy
lgtm
4 years, 1 month ago (2016-11-17 02:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510633002/1
4 years, 1 month ago (2016-11-17 06:08:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 06:41:50 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d258b35c8698d5be5f01f3fb5693ac5b42efb27
Cr-Commit-Position: refs/heads/master@{#41060}

Powered by Google App Engine
This is Rietveld 408576698