Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 27701002: Expose v8::Function::IsBuiltin to public API. (Closed)

Created:
7 years, 2 months ago by aandrey
Modified:
7 years, 2 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Expose v8::Function::IsBuiltin to public API. This will be used by DevTools so that we could generate a better preview in console. Namely, we could assume that a preview of an object is lossless if all its member functions are builtin. We also may want to expose this to DevTools users via remote debugging protocol in Debugger.FunctionDetails struct. BUG=chromium:261470 R=mstarzinger@chromium.org, yurys@chromium.org, dcarney@chromium.org, yurys Committed: https://code.google.com/p/v8/source/detail?r=17323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aandrey
7 years, 2 months ago (2013-10-17 12:40:55 UTC) #1
yurys
Can you add to the description some details on why we need to expose this ...
7 years, 2 months ago (2013-10-17 13:30:25 UTC) #2
aandrey
On 2013/10/17 13:30:25, Yury Semikhatsky wrote: > Can you add to the description some details ...
7 years, 2 months ago (2013-10-17 13:40:16 UTC) #3
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-10-17 15:16:40 UTC) #4
yurys
Is it possible to detect builtin functions based on their v8::Function::ScriptId() property?
7 years, 2 months ago (2013-10-18 13:24:05 UTC) #5
aandrey
On 2013/10/18 13:24:05, Yury Semikhatsky wrote: > Is it possible to detect builtin functions based ...
7 years, 2 months ago (2013-10-22 10:05:11 UTC) #6
yurys
lgtm
7 years, 2 months ago (2013-10-22 12:24:22 UTC) #7
yurys
7 years, 2 months ago (2013-10-22 14:50:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r17323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698