Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2510553002: [turbofan] Specialize to (optimization time) known TypedArray instances. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Specialize to (optimization time) known TypedArray instances. When we have a known JSTypedArray instance at optimization time, i.e. as in asm.js-like use cases and also when there are global typed arrays that are tracked via global object property constant tracking, we can generate more efficient code in that case by specializing to the immutable internal fields of the JSTypedArray (and the JSArrayBuffer backing it). R=jarin@chromium.org BUG=v8:4470, v8:5267 Committed: https://crrev.com/4db73ae0e023df5ede7107a7bf2e2509c00c7021 Cr-Commit-Position: refs/heads/master@{#41017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -48 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 8 chunks +96 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-16 06:03:24 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first fix for Mandreel performance, which does the asm.js-like specialization even ...
4 years, 1 month ago (2016-11-16 06:04:20 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-16 07:35:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510553002/1
4 years, 1 month ago (2016-11-16 07:47:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 07:49:08 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db73ae0e023df5ede7107a7bf2e2509c00c7021
Cr-Commit-Position: refs/heads/master@{#41017}

Powered by Google App Engine
This is Rietveld 408576698