Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2504123002: [turbofan][x64] Try harder to use memory addressing modes. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][x64] Try harder to use memory addressing modes. When we don't have a base, and the displacement returned by the BaseWithIndexAndDisplacement64Matcher cannot be encoded as immediate, we can still try to utilize the scale factor matching by just using the displacement as base. This happens when we do indexed memory accesses to known addresses. R=jarin@chromium.org Committed: https://crrev.com/f16a7fe37c80a6fd13fe059c66e9791a870157f0 Cr-Commit-Position: refs/heads/master@{#41016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +9 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-16 05:21:57 UTC) #1
Benedikt Meurer
Hey Jaro, Ran across this while doing the Mandreel constant typed array stuff. Please take ...
4 years, 1 month ago (2016-11-16 05:24:17 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-16 07:36:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504123002/1
4 years, 1 month ago (2016-11-16 07:36:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 07:38:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f16a7fe37c80a6fd13fe059c66e9791a870157f0
Cr-Commit-Position: refs/heads/master@{#41016}

Powered by Google App Engine
This is Rietveld 408576698