[Cronet] Retain block passed to setRequestFilterBlock on iOS.

[Cronet] Retain block passed to setRequestFilterBlock on iOS.

BUG=665590
Committed: https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84
Cr-Commit-Position: refs/heads/master@{#432571}

[mef, 2016-11-15 22:27:46]

mef@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[mef, 2016-11-16 16:32:29]

Hi Andrei, PTAL, I've tweaked tests per our discussion.

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
File components/cronet/ios/test/test_server.cc (right):

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
components/cronet/ios/test/test_server.cc:47:
net::EmbeddedTestServer::TYPE_HTTP);
I had to switch to HTTP as platform stack doesn't trust the self signed cert.

[kapishnikov, 2016-11-16 17:58:53]

Looks good. One optional comment below. LGTM.

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
File components/cronet/ios/test/cronet_http_test.mm (right):

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
components/cronet/ios/test/cronet_http_test.mm:231: EXPECT_STRNE(kUserAgent,
nit: We can make this assert stronger by using 'containsString' instead of
strict equality. It is just in case if in the future we prepend something to
kUserAgent by mistake. Something like:

EXPECT_FALSE([[delegate_ responseBody] containsString:[NSString   
stringWithCString:kUserAgent ...]);

[mef, 2016-11-16 18:11:11]

Thanks!

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
File components/cronet/ios/test/cronet_http_test.mm (right):

https://codereview.chromium.org/2510463002/diff/40001/components/cronet/ios/t...
components/cronet/ios/test/cronet_http_test.mm:231: EXPECT_STRNE(kUserAgent,
On 2016/11/16 17:58:53, kapishnikov wrote:
> nit: We can make this assert stronger by using 'containsString' instead of
> strict equality. It is just in case if in the future we prepend something to
> kUserAgent by mistake. Something like:
> 
> EXPECT_FALSE([[delegate_ responseBody] containsString:[NSString   
> stringWithCString:kUserAgent ...]);

Done.

[mef, 2016-11-16 18:11:34]

The CQ bit was checked by mef@chromium.org

[mef, 2016-11-16 18:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kapishnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2510463002/#ps60001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-11-16 18:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:42:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-16 18:52:55]

Description was changed from

==========
[Cronet] Retain block passed to setRequestFilterBlock on iOS.

BUG=665590
==========

to

==========
[Cronet] Retain block passed to setRequestFilterBlock on iOS.

BUG=665590

Committed: https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84
Cr-Commit-Position: refs/heads/master@{#432571}
==========

[commit-bot: I haz the power, 2016-11-16 18:52:56]

Patchset 4 (id:??) landed as
https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84
Cr-Commit-Position: refs/heads/master@{#432571}