components/cronet/ios/Cronet.mm - Issue 2510463002: [Cronet] Retain block passed to setRequestFilterBlock on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/Cronet.mm

Issue 2510463002: [Cronet] Retain block passed to setRequestFilterBlock on iOS. (Closed)

Patch Set: Address comment. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/ios/Cronet.mm

diff --git a/components/cronet/ios/Cronet.mm b/components/cronet/ios/Cronet.mm

index d413f97de704039f29790589dff8d5ff0b7e70d9..1fd0c3d99e0d12635e12cd4058532fee2b54c16f 100644

--- a/components/cronet/ios/Cronet.mm

+++ b/components/cronet/ios/Cronet.mm

@@ -67,7 +67,7 @@ class CronetHttpProtocolHandlerDelegate

void SetRequestFilterBlock(RequestFilterBlock filter) {

base::AutoLock auto_lock(lock_);

- filter_.reset(filter);

+ filter_.reset(filter, base::scoped_policy::RETAIN);

}

private:

« no previous file with comments | « no previous file | components/cronet/ios/test/cronet_http_test.mm » ('j') | no next file with comments »