Issue 251046: Make the cache columns in the Task Manager sortable and only displayed once p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251046: Make the cache columns in the Task Manager sortable and only displayed once p... (Closed)

Created:
11 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
jamesr, Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the cache columns in the Task Manager sortable and only displayed once per process on GTK and Mac, just like was already done on Windows. BUG=16221 TEST=Open Task Manager on GTK or Mac, add a WebCore Cache column, see that it only prints one line of output per process, and verify it's sortable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27657

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -2 lines)			Patch
MM	chrome/browser/cocoa/task_manager_mac.mm	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/task_manager_gtk.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/task_manager_gtk.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

This is a blind fix, but the code looks simple enough.

11 years, 2 months ago (2009-09-30 19:54:39 UTC) #1

jamesr

LGTM. +cc thakis in case he wants to look over the GTK code since I ...

11 years, 2 months ago (2009-09-30 21:13:24 UTC) #2

LGTM. Thanks for doing this :-)

Expand Messages | Collapse Messages