Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/cocoa/task_manager_mac.mm

Issue 251046: Make the cache columns in the Task Manager sortable and only displayed once p... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/task_manager_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/task_manager_mac.mm
===================================================================
--- chrome/browser/cocoa/task_manager_mac.mm (revision 27637)
+++ chrome/browser/cocoa/task_manager_mac.mm (working copy)
@@ -62,7 +62,7 @@
initWithIdentifier:[NSNumber numberWithInt:columnId]]);
NSTextAlignment textAlignment = columnId == IDS_TASK_MANAGER_PAGE_COLUMN ?
- NSLeftTextAlignment : NSRightTextAlignment;
+ NSLeftTextAlignment : NSRightTextAlignment;
[[column.get() headerCell]
setStringValue:l10n_util::GetNSStringWithFixup(columnId)];
@@ -125,7 +125,7 @@
[column setHidden:newState == NSOffState];
[item setState:newState];
[tableView_ sizeToFit];
- [tableView_ setNeedsDisplay];
+ [tableView_ setNeedsDisplay];
}
@end
@@ -171,14 +171,20 @@
return base::SysWideToNSString(model_->GetResourceProcessId(row));
case IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN: // WebCore image cache
+ if (!model_->IsResourceFirstInGroup(row))
+ return @"";
return base::SysWideToNSString(
model_->GetResourceWebCoreImageCacheSize(row));
case IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN: // WebCore script cache
+ if (!model_->IsResourceFirstInGroup(row))
+ return @"";
return base::SysWideToNSString(
model_->GetResourceWebCoreScriptsCacheSize(row));
case IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN: // WebCore CSS cache
+ if (!model_->IsResourceFirstInGroup(row))
+ return @"";
return base::SysWideToNSString(
model_->GetResourceWebCoreCSSCacheSize(row));
Property changes on: chrome\browser\cocoa\task_manager_mac.mm
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « no previous file | chrome/browser/gtk/task_manager_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698