Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 251025: Enable ExtensionApiTest.Toolstrip and add additional debug output (Closed)

Created:
11 years, 2 months ago by rafaelw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable ExtensionApiTest.Toolstrip and add additional debug output. This output is testing the prospect that the cause of the flakiness is a race to the IO thread between the renderer that is requesting a chrome-extension page and the message to insert the correct mapping to service the request. BUG=22668 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27516

Patch Set 1 #

Patch Set 2 : more cowbell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolstrip_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rafaelw
Looking hard at the code, our current idea seems most likely, but i still find ...
11 years, 2 months ago (2009-09-29 18:08:08 UTC) #1
Aaron Boodman
11 years, 2 months ago (2009-09-29 18:14:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698