Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: net/url_request/url_request_job_manager.cc

Issue 251025: Enable ExtensionApiTest.Toolstrip and add additional debug output (Closed)
Patch Set: more cowbell Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_toolstrip_apitest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job_manager.h" 5 #include "net/url_request/url_request_job_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 if (scheme == kBuiltinFactories[i].scheme) { 92 if (scheme == kBuiltinFactories[i].scheme) {
93 URLRequestJob* job = (kBuiltinFactories[i].factory)(request, scheme); 93 URLRequestJob* job = (kBuiltinFactories[i].factory)(request, scheme);
94 DCHECK(job); // The built-in factories are not expected to fail! 94 DCHECK(job); // The built-in factories are not expected to fail!
95 return job; 95 return job;
96 } 96 }
97 } 97 }
98 98
99 // If we reached here, then it means that a registered protocol factory 99 // If we reached here, then it means that a registered protocol factory
100 // wasn't interested in handling the URL. That is fairly unexpected, and we 100 // wasn't interested in handling the URL. That is fairly unexpected, and we
101 // don't know have a specific error to report here :-( 101 // don't know have a specific error to report here :-(
102 LOG(WARNING) << "Failed to map: " << request->url().spec();
102 return new URLRequestErrorJob(request, net::ERR_FAILED); 103 return new URLRequestErrorJob(request, net::ERR_FAILED);
103 } 104 }
104 105
105 URLRequestJob* URLRequestJobManager::MaybeInterceptRedirect( 106 URLRequestJob* URLRequestJobManager::MaybeInterceptRedirect(
106 URLRequest* request, 107 URLRequest* request,
107 const GURL& location) const { 108 const GURL& location) const {
108 #ifndef NDEBUG 109 #ifndef NDEBUG
109 DCHECK(IsAllowedThread()); 110 DCHECK(IsAllowedThread());
110 #endif 111 #endif
111 if ((request->load_flags() & net::LOAD_DISABLE_INTERCEPT) || 112 if ((request->load_flags() & net::LOAD_DISABLE_INTERCEPT) ||
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 DCHECK(IsAllowedThread()); 202 DCHECK(IsAllowedThread());
202 #endif 203 #endif
203 204
204 AutoLock locked(lock_); 205 AutoLock locked(lock_);
205 206
206 InterceptorList::iterator i = 207 InterceptorList::iterator i =
207 std::find(interceptors_.begin(), interceptors_.end(), interceptor); 208 std::find(interceptors_.begin(), interceptors_.end(), interceptor);
208 DCHECK(i != interceptors_.end()); 209 DCHECK(i != interceptors_.end());
209 interceptors_.erase(i); 210 interceptors_.erase(i);
210 } 211 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_toolstrip_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698