Make CPDF_Dictionary use unique pointers.

core/fpdfapi/parser/cpdf_string.h

Index: core/fpdfapi/parser/cpdf_string.h
diff --git a/core/fpdfapi/parser/cpdf_string.h b/core/fpdfapi/parser/cpdf_string.h
index 616e3b593de6a5948b680ad376922e73945088e8..98b878132070b926dc881178fd40fc284e2a3320 100644
--- a/core/fpdfapi/parser/cpdf_string.h
+++ b/core/fpdfapi/parser/cpdf_string.h
@@ -19,7 +19,7 @@ class CPDF_String : public CPDF_Object {
   CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool,
               const CFX_ByteString& str,
               bool bHex);
-  explicit CPDF_String(const CFX_WideString& str);
+  CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool, const CFX_WideString& str);

[Lei Zhang, 2016/11/18 23:28:35]

If we have this new ctor, then can we change a bunch of the

pDict->SetNewFor<CPDF_String>(key, str, false) calls to just
pDict->SetNewFor<CPDF_String>(key, str) ?

[Lei Zhang, 2016/11/18 23:58:59]

Oh, I missed ByteString vs WideString, n/m.

   ~CPDF_String() override;
 
   // CPDF_Object: