Make CPDF_Dictionary use unique pointers.

core/fpdfapi/parser/cpdf_string.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_FPDFAPI_PARSER_CPDF_STRING_H_
 #define CORE_FPDFAPI_PARSER_CPDF_STRING_H_
 
 #include "core/fpdfapi/parser/cpdf_object.h"
 #include "core/fxcrt/cfx_string_pool_template.h"
 #include "core/fxcrt/cfx_weak_ptr.h"
 #include "core/fxcrt/fx_string.h"
 #include "core/fxcrt/fx_system.h"
 
 class CPDF_String : public CPDF_Object {
  public:
   CPDF_String();
   CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool,
               const CFX_ByteString& str,
               bool bHex);
-  explicit CPDF_String(const CFX_WideString& str);
+  CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool, const CFX_WideString& str);

[Lei Zhang, 2016/11/18 23:28:35]

If we have this new ctor, then can we change a bunch of the

pDict->SetNewFor<CPDF_String>(key, str, false) calls to just
pDict->SetNewFor<CPDF_String>(key, str) ?

[Lei Zhang, 2016/11/18 23:58:59]

Oh, I missed ByteString vs WideString, n/m.

   ~CPDF_String() override;
 
   // CPDF_Object:
   Type GetType() const override;
   std::unique_ptr<CPDF_Object> Clone() const override;
   CFX_ByteString GetString() const override;
   CFX_WideString GetUnicodeText() const override;
   void SetString(const CFX_ByteString& str) override;
   bool IsString() const override;
   CPDF_String* AsString() override;
   const CPDF_String* AsString() const override;
 
   bool IsHex() const { return m_bHex; }
 
  protected:
   CFX_ByteString m_String;
   bool m_bHex;
 };
 
 inline CPDF_String* ToString(CPDF_Object* obj) {
   return obj ? obj->AsString() : nullptr;
 }
 
 inline const CPDF_String* ToString(const CPDF_Object* obj) {
   return obj ? obj->AsString() : nullptr;
 }
 
 #endif  // CORE_FPDFAPI_PARSER_CPDF_STRING_H_