Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2510143002: Don't crash trying to use --snapshot-kind=app-aot from 'dart' rather than 'dart_bootstrap'. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't crash trying to use --snapshot-kind=app-aot from 'dart' rather than 'dart_bootstrap'. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f4baefeb2502d3878e7ac50bfe3700dafea20980

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-17 18:22:01 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-17 18:28:33 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-17 18:34:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f4baefeb2502d3878e7ac50bfe3700dafea20980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698