Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2510143002: Don't crash trying to use --snapshot-kind=app-aot from 'dart' rather than 'dart_bootstrap'. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index e5cf6ae42b6d7fd580c2346b723f7ec4f1550c95..38545ea4e522b1e827e63dc71f256bc34f5c10dc 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -6326,15 +6326,16 @@ DART_EXPORT void Dart_SetThreadName(const char* name) {
DART_EXPORT Dart_Handle
Dart_Precompile(Dart_QualifiedFunctionName entry_points[], bool reset_fields) {
- UNREACHABLE();
- return 0;
+ return Api::NewError(
+ "This VM was built without support for AOT compilation.");
}
DART_EXPORT Dart_Handle
Dart_CreatePrecompiledSnapshotAssembly(uint8_t** assembly_buffer,
intptr_t* assembly_size) {
- UNREACHABLE();
+ return Api::NewError(
+ "This VM was built without support for AOT compilation.");
return 0;
}
@@ -6348,8 +6349,8 @@ Dart_CreatePrecompiledSnapshotBlob(uint8_t** vm_isolate_snapshot_buffer,
intptr_t* instructions_blob_size,
uint8_t** rodata_blob_buffer,
intptr_t* rodata_blob_size) {
- UNREACHABLE();
- return 0;
+ return Api::NewError(
+ "This VM was built without support for AOT compilation.");
}
#else // DART_PRECOMPILER
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698