Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/browser/loader/navigation_url_loader_impl_core.cc

Issue 2510083003: PlzNavigate: properly update NavigationHandle for 204/205 and download responses (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_url_loader_impl_core.cc
diff --git a/content/browser/loader/navigation_url_loader_impl_core.cc b/content/browser/loader/navigation_url_loader_impl_core.cc
index 9a35c9e247fbcd71e05bc6a2e5a92ffbbce55d90..39cda65a0d6f73de2d491c1ff48e9f625e9db646 100644
--- a/content/browser/loader/navigation_url_loader_impl_core.cc
+++ b/content/browser/loader/navigation_url_loader_impl_core.cc
@@ -100,7 +100,8 @@ void NavigationURLLoaderImplCore::NotifyResponseStarted(
ResourceResponse* response,
std::unique_ptr<StreamHandle> body,
const SSLStatus& ssl_status,
- std::unique_ptr<NavigationData> navigation_data) {
+ std::unique_ptr<NavigationData> navigation_data,
+ bool is_download) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
TRACE_EVENT_ASYNC_END0("navigation", "Navigation redirectDelay", this);
TRACE_EVENT_ASYNC_END2("navigation", "Navigation timeToResponseStarted", this,
@@ -119,7 +120,7 @@ void NavigationURLLoaderImplCore::NotifyResponseStarted(
BrowserThread::UI, FROM_HERE,
base::Bind(&NavigationURLLoaderImpl::NotifyResponseStarted, loader_,
response->DeepCopy(), base::Passed(&body), ssl_status,
- base::Passed(&navigation_data)));
+ base::Passed(&navigation_data), is_download));
}
void NavigationURLLoaderImplCore::NotifyRequestFailed(bool in_cache,

Powered by Google App Engine
This is Rietveld 408576698