content/browser/loader/navigation_url_loader_impl_core.h - Issue 2510083003: PlzNavigate: properly update NavigationHandle for 204/205 and download responses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_impl_core.h

Issue 2510083003: PlzNavigate: properly update NavigationHandle for 204/205 and download responses (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/navigation_url_loader_impl_core.h

diff --git a/content/browser/loader/navigation_url_loader_impl_core.h b/content/browser/loader/navigation_url_loader_impl_core.h

index dd55af60123e4142f7735f233819b7f74bfb6738..ee2d9f65130f850ca2778526f3ccf4b2e58c2a7c 100644

--- a/content/browser/loader/navigation_url_loader_impl_core.h

+++ b/content/browser/loader/navigation_url_loader_impl_core.h

@@ -62,7 +62,8 @@ class NavigationURLLoaderImplCore {

void NotifyResponseStarted(ResourceResponse* response,

std::unique_ptr<StreamHandle> body,

const SSLStatus& ssl_status,

- std::unique_ptr<NavigationData> navigation_data);

+ std::unique_ptr<NavigationData> navigation_data,

+ bool is_download);

// Notifies |loader_| on the UI thread that the request failed.

void NotifyRequestFailed(bool in_cache, int net_error);