Implement StructTraits for remaining IndexedDB IPC types.

Implement StructTraits for remaining IndexedDB IPC types.

This patch implements StructTraits for IndexedDBKey, IndexedDBKeyPath
and IndexedDBKeyRange. The ParamTraits for IndexedDBKeyPath can now be
removed as unused.

BUG=627484
Committed: https://crrev.com/aa36693fe3dded933a2cae51a23dba720f91b37d
Cr-Commit-Position: refs/heads/master@{#434070}

[Reilly Grant (use Gerrit), 2016-11-17 00:07:13]

reillyg@chromium.org changed reviewers:
+ jsbell@chromium.org, kenrb@chromium.org

[Reilly Grant (use Gerrit), 2016-11-17 00:07:14]

kenrb@, IPC security review please.
jsbell@, IndexedDB review please.

[jsbell, 2016-11-17 04:32:42]

lgtm

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
File content/common/indexed_db/indexed_db.mojom (right):

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
content/common/indexed_db/indexed_db.mojom:39: DatalessKeyType other;
Ugh. I remember this falling out of very early WebKit implementation. In theory
a Key should be just union {array, binary, string, date, number} and be nullable
in certain places (e.g. KeyRange)

This is probably fine for now but we should add a big TODO to clean this up end
to end.

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
File content/common/indexed_db/indexed_db_struct_traits.cc (right):

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
content/common/indexed_db/indexed_db_struct_traits.cc:21: case
blink::WebIDBKeyTypeInvalid:
I'd love to figure out where Invalid may be coming from. But not this CL.

[Reilly Grant (use Gerrit), 2016-11-17 21:31:05]

Add jsbell@'s TODO.

[Reilly Grant (use Gerrit), 2016-11-17 21:31:17]

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
File content/common/indexed_db/indexed_db.mojom (right):

https://codereview.chromium.org/2509913002/diff/1/content/common/indexed_db/i...
content/common/indexed_db/indexed_db.mojom:39: DatalessKeyType other;
On 2016/11/17 at 04:32:42, jsbell wrote:
> Ugh. I remember this falling out of very early WebKit implementation. In
theory a Key should be just union {array, binary, string, date, number} and be
nullable in certain places (e.g. KeyRange)
> 
> This is probably fine for now but we should add a big TODO to clean this up
end to end.

Added a little TODO.

[kenrb, 2016-11-17 23:09:48]

ipc lgtm

[Reilly Grant (use Gerrit), 2016-11-19 01:28:42]

Rebased.

[Reilly Grant (use Gerrit), 2016-11-19 01:33:35]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 01:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 01:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 01:54:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Reilly Grant (use Gerrit), 2016-11-19 02:29:03]

Fix compile error on GCC.

[Reilly Grant (use Gerrit), 2016-11-19 02:29:07]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 02:29:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 04:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 04:47:38]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-11-22 20:48:20]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-11-22 20:48:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org,
kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2509913002/#ps60001
(title: "Fix compile error on GCC.")

[commit-bot: I haz the power, 2016-11-22 20:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 20:48:57]

This CL has an open dependency (Issue 2507233002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Reilly Grant (use Gerrit), 2016-11-22 22:04:36]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:05:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:55:57]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-11-23 01:10:00]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:10:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:23:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479863400527030,
"parent_rev": "d323020e61afe5adb5245cba41a566e935e80a86", "commit_rev":
"b29f188248b42f971138aaa4567ab6892be759d6"}

[commit-bot: I haz the power, 2016-11-23 01:23:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-23 01:28:04]

Description was changed from

==========
Implement StructTraits for remaining IndexedDB IPC types.

This patch implements StructTraits for IndexedDBKey, IndexedDBKeyPath
and IndexedDBKeyRange. The ParamTraits for IndexedDBKeyPath can now be
removed as unused.

BUG=627484
==========

to

==========
Implement StructTraits for remaining IndexedDB IPC types.

This patch implements StructTraits for IndexedDBKey, IndexedDBKeyPath
and IndexedDBKeyRange. The ParamTraits for IndexedDBKeyPath can now be
removed as unused.

BUG=627484

Committed: https://crrev.com/aa36693fe3dded933a2cae51a23dba720f91b37d
Cr-Commit-Position: refs/heads/master@{#434070}
==========

[commit-bot: I haz the power, 2016-11-23 01:28:05]

Patchset 4 (id:??) landed as
https://crrev.com/aa36693fe3dded933a2cae51a23dba720f91b37d
Cr-Commit-Position: refs/heads/master@{#434070}