Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2507233002: Define EnumTraits for many IndexedDB enums. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, cmumford, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, jsbell+idb_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define EnumTraits for many IndexedDB enums. This moves the serialization code for the following IndexedDB enum types from indexed_db_messages.h to indexed_db_enum_traits.h: * CursorDirection * DataLoss * PutMode * TaskType * TransactionMode The remaining enum, OperationType, is used for IDBObservers which have not yet been converted to Mojo. BUG=627484 Committed: https://crrev.com/7793cc56cff1379a30a7d46f6f2d0684de56dec4 Cr-Commit-Position: refs/heads/master@{#434034}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : GCC doesn't trust exhaustive switch statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -23 lines) Patch
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db.mojom View 2 chunks +24 lines, -10 lines 0 comments Download
M content/common/indexed_db/indexed_db.typemap View 1 chunk +1 line, -1 line 0 comments Download
A content/common/indexed_db/indexed_db_enum_traits.h View 1 chunk +54 lines, -0 lines 0 comments Download
A content/common/indexed_db/indexed_db_enum_traits.cc View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (20 generated)
Reilly Grant (use Gerrit)
kenrb@ for IPC security review. jsbell@ for IndexedDB review.
4 years, 1 month ago (2016-11-16 21:18:26 UTC) #4
kenrb
ipc lgtm
4 years, 1 month ago (2016-11-16 21:40:01 UTC) #5
jsbell
lgtm
4 years, 1 month ago (2016-11-16 22:08:03 UTC) #6
Reilly Grant (use Gerrit)
Rebased.
4 years, 1 month ago (2016-11-19 01:26:38 UTC) #9
Reilly Grant (use Gerrit)
GCC doesn't trust exhaustive switch statements.
4 years, 1 month ago (2016-11-19 02:05:20 UTC) #14
Reilly Grant (use Gerrit)
avi@, please review content/common/BUILD.gn.
4 years, 1 month ago (2016-11-19 02:10:18 UTC) #18
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-19 03:52:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507233002/40001
4 years, 1 month ago (2016-11-22 20:34:58 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-23 00:04:50 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:08:27 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7793cc56cff1379a30a7d46f6f2d0684de56dec4
Cr-Commit-Position: refs/heads/master@{#434034}

Powered by Google App Engine
This is Rietveld 408576698