Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2509853002: Convert //mash to define service names in mojom (Closed)

Created:
4 years, 1 month ago by Ben Goodger (Google)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //mash to define service names in mojom TBR=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/da8093baa2fccc9a4c0f4a86c9e641ad5d3b8283 Cr-Commit-Position: refs/heads/master@{#433394}

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -69 lines) Patch
M ash/BUILD.gn View 1 4 chunks +16 lines, -3 lines 0 comments Download
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/new_window_client_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/wallpaper/wallpaper_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/mus/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/mus/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/mus/app_launch_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/app_list_presenter_mus.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/shutdown_policy_forwarder.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_client.cc View 2 chunks +6 lines, -3 lines 0 comments Download
A + mash/browser/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/browser/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/browser/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
A + mash/catalog_viewer/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/catalog_viewer/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/catalog_viewer/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
A + mash/example/window_type_launcher/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/example/window_type_launcher/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/example/window_type_launcher/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M mash/init/init.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mash/init/public/interfaces/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A mash/init/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/init/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/login/login.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mash/login/public/interfaces/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A mash/login/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/login/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/package/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/package/mash_packaged_service.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
A + mash/quick_launch/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/quick_launch/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/quick_launch/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/quick_launch/quick_launch.h View 2 chunks +7 lines, -7 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mash/screenlock/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/screenlock/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/screenlock/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/screenlock/screenlock.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mash/session/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A mash/session/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M mash/session/public/interfaces/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A mash/session/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/session/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/session/session.cc View 5 chunks +11 lines, -5 lines 0 comments Download
A + mash/task_viewer/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/task_viewer/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/task_viewer/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 2 chunks +9 lines, -8 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mash/webtest/public/interfaces/BUILD.gn View 1 1 chunk +8 lines, -2 lines 0 comments Download
A mash/webtest/public/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/webtest/public/interfaces/constants.mojom View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 65 (43 generated)
Ben Goodger (Google)
4 years, 1 month ago (2016-11-16 21:54:58 UTC) #5
Ben Goodger (Google)
4 years, 1 month ago (2016-11-17 20:22:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/80001
4 years, 1 month ago (2016-11-17 21:42:40 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/338062)
4 years, 1 month ago (2016-11-17 22:40:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/100001
4 years, 1 month ago (2016-11-17 22:45:55 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/237372)
4 years, 1 month ago (2016-11-18 00:12:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/120001
4 years, 1 month ago (2016-11-18 00:38:44 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/300619)
4 years, 1 month ago (2016-11-18 01:40:07 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/140001
4 years, 1 month ago (2016-11-18 04:52:23 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/237509) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-18 05:14:14 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/160001
4 years, 1 month ago (2016-11-18 06:09:28 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275483)
4 years, 1 month ago (2016-11-18 07:39:09 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/160001
4 years, 1 month ago (2016-11-18 14:52:33 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275664)
4 years, 1 month ago (2016-11-18 15:55:40 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/160001
4 years, 1 month ago (2016-11-18 16:12:15 UTC) #44
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-11-18 17:19:34 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275782)
4 years, 1 month ago (2016-11-18 17:52:04 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/180001
4 years, 1 month ago (2016-11-18 23:15:07 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/318438)
4 years, 1 month ago (2016-11-19 01:30:05 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509853002/180001
4 years, 1 month ago (2016-11-19 03:17:52 UTC) #62
commit-bot: I haz the power
Committed patchset #2 (id:180001)
4 years, 1 month ago (2016-11-19 03:58:59 UTC) #63
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 04:01:08 UTC) #65
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da8093baa2fccc9a4c0f4a86c9e641ad5d3b8283
Cr-Commit-Position: refs/heads/master@{#433394}

Powered by Google App Engine
This is Rietveld 408576698