Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ash/BUILD.gn

Issue 2509853002: Convert //mash to define service names in mojom (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/BUILD.gn
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index 83eb0588d058d00dd214b5106530a9189fe11ada..1f087c8e36f8549fd2852d42e25851513dd7aa33 100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -853,6 +853,10 @@ component("ash") {
"//ash/resources",
"//ash/resources/vector_icons",
"//ash/shared:app_types",
+
+ # This is a tiny dependency that just defines some service name strings & is
+ # not equivalent to depending on content in a more substantial manner.
+ "//content/public/common:service_names",
]
deps = [
"//ash/autoclick/common:autoclick",
@@ -994,7 +998,10 @@ component("ash") {
}
# Usage of content should be in ash_content_unittests.
- assert_no_deps = [ "//content/*" ]
+ assert_no_deps = [
+ "//content/public/browser",
+ "//content/public/common",
+ ]
}
component("ash_with_content") {
@@ -1064,7 +1071,10 @@ static_library("ash_shell_lib") {
]
# Usage of content should be in ash_shell_lib_with_content.
- assert_no_deps = [ "//content/*" ]
+ assert_no_deps = [
+ "//content/public/browser",
+ "//content/public/common",
+ ]
deps = [
":ash",
@@ -1467,7 +1477,10 @@ test("ash_unittests") {
}
# Usage of content should be in ash_with_content.
- assert_no_deps = [ "//content/*" ]
+ assert_no_deps = [
+ "//content/public/browser",
+ "//content/public/common",
+ ]
}
executable("ash_shell_with_content") {
« no previous file with comments | « no previous file | ash/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698