Assert !NativeCallInstr::link_lazily() on ia32

Assert !NativeCallInstr::link_lazily() on ia32

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/89315c9570591642620f2a66f8d56499ffb8a825

[kustermann, 2016-11-16 21:03:11]

kustermann@google.com changed reviewers:
+ fschneider@google.com

[kustermann, 2016-11-16 21:03:12]

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:850: ASSERT(!link_lazily());
This property is guaranteed in flow_graph_compiler.cc (since
FLAG_link_natives_lazily is only set to true on precompilation runs)

[Florian Schneider, 2016-11-16 21:08:28]

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:850: ASSERT(!link_lazily());
On 2016/11/16 21:03:12, kustermann wrote:
> This property is guaranteed in flow_graph_compiler.cc (since
> FLAG_link_natives_lazily is only set to true on precompilation runs)

We have a test that runs with this flag on all platforms, and we'd have to skip
this one (link_natives_lazily_test)

Maybe just s/GeneratePatchableCall/GenerateCall/

[kustermann, 2016-11-16 21:12:13]

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:850: ASSERT(!link_lazily());
On 2016/11/16 21:08:28, Florian Schneider wrote:
> On 2016/11/16 21:03:12, kustermann wrote:
> > This property is guaranteed in flow_graph_compiler.cc (since
> > FLAG_link_natives_lazily is only set to true on precompilation runs)
> 
> We have a test that runs with this flag on all platforms, and we'd have to
skip
> this one (link_natives_lazily_test)
> 
> Maybe just s/GeneratePatchableCall/GenerateCall/


But the code emitted will simply not work, because
NativeEntry::LinkNativeCallEntry() will call CodePatcher::GetNativeCallAt()
which is UNREACHABLE().

:-/

In fact:

tests/standalone/standalone.status:
210 [ $arch == ia32 ]
211 no_allow_absolute_addresses_test: SkipByDesign # Not supported.
212 link_natives_lazily_test: SkipByDesign # Not supported.

[Florian Schneider, 2016-11-16 21:25:03]

lgtm

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/2509843002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:850: ASSERT(!link_lazily());
On 2016/11/16 21:12:13, kustermann wrote:
> On 2016/11/16 21:08:28, Florian Schneider wrote:
> > On 2016/11/16 21:03:12, kustermann wrote:
> > > This property is guaranteed in flow_graph_compiler.cc (since
> > > FLAG_link_natives_lazily is only set to true on precompilation runs)
> > 
> > We have a test that runs with this flag on all platforms, and we'd have to
> skip
> > this one (link_natives_lazily_test)
> > 
> > Maybe just s/GeneratePatchableCall/GenerateCall/
> 
> 
> But the code emitted will simply not work, because
> NativeEntry::LinkNativeCallEntry() will call CodePatcher::GetNativeCallAt()
> which is UNREACHABLE().
> 
> :-/
> 
> In fact:
> 
> tests/standalone/standalone.status:
> 210 [ $arch == ia32 ]
> 211 no_allow_absolute_addresses_test: SkipByDesign # Not supported.
> 212 link_natives_lazily_test: SkipByDesign # Not supported.

Oh ok. Right. Then it's fine to add the assertion here.

[kustermann, 2016-11-17 14:14:30]

Description was changed from

==========
Assert !NativeCallInstr::link_lazily() on ia32
==========

to

==========
Assert !NativeCallInstr::link_lazily() on ia32

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/89315c9570591642620f2a66f8d56499ffb8a825
==========

[kustermann, 2016-11-17 14:14:32]

Committed patchset #1 (id:1) manually as
89315c9570591642620f2a66f8d56499ffb8a825 (presubmit successful).