Assert !NativeCallInstr::link_lazily() on ia32

runtime/vm/intermediate_language_ia32.cc

Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index c90b2c52d8fd2e0f4dbb60b6c3854b37104c1130..c3f905ded2b672a51a4838c9bd1bc7ffa6f95576 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -845,20 +845,17 @@ void NativeCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   __ movl(EDX, Immediate(argc_tag));
 
   const StubEntry* stub_entry;
-  if (link_lazily()) {
-    stub_entry = StubCode::CallBootstrapCFunction_entry();
-    __ movl(ECX, Immediate(NativeEntry::LinkNativeCallEntry()));
-    compiler->GeneratePatchableCall(token_pos(), *stub_entry,
-                                    RawPcDescriptors::kOther, locs());
-  } else {
-    stub_entry = (is_bootstrap_native())
-                     ? StubCode::CallBootstrapCFunction_entry()
-                     : StubCode::CallNativeCFunction_entry();
-    const ExternalLabel label(reinterpret_cast<uword>(native_c_function()));
-    __ movl(ECX, Immediate(label.address()));
-    compiler->GenerateCall(token_pos(), *stub_entry, RawPcDescriptors::kOther,
-                           locs());
-  }
+
+  // There is no lazy-linking support on ia32.
+  ASSERT(!link_lazily());

[kustermann, 2016/11/16 21:03:12]

This property is guaranteed in flow_graph_compiler.cc (since
FLAG_link_natives_lazily is only set to true on precompilation runs)

[Florian Schneider, 2016/11/16 21:08:28]

We have a test that runs with this flag on all platforms, and we'd have to skip
this one (link_natives_lazily_test)

Maybe just s/GeneratePatchableCall/GenerateCall/

[kustermann, 2016/11/16 21:12:13]

But the code emitted will simply not work, because
NativeEntry::LinkNativeCallEntry() will call CodePatcher::GetNativeCallAt()
which is UNREACHABLE().

:-/

In fact:

tests/standalone/standalone.status:
210 [ $arch == ia32 ]
211 no_allow_absolute_addresses_test: SkipByDesign # Not supported.
212 link_natives_lazily_test: SkipByDesign # Not supported.

[Florian Schneider, 2016/11/16 21:25:02]

Oh ok. Right. Then it's fine to add the assertion here.

+  stub_entry = (is_bootstrap_native())
+                   ? StubCode::CallBootstrapCFunction_entry()
+                   : StubCode::CallNativeCFunction_entry();
+  const ExternalLabel label(reinterpret_cast<uword>(native_c_function()));
+  __ movl(ECX, Immediate(label.address()));
+  compiler->GenerateCall(token_pos(), *stub_entry, RawPcDescriptors::kOther,
+                         locs());
+
   __ popl(result);
 }