HeadlessWebContents:Observer to observe render process exit status

headless/app/headless_shell.cc

Index: headless/app/headless_shell.cc
diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc
index b57fc5f9070de1e36aa9bfb743c76945ef53ca64..d9c6c23a89355924627ec53ee617a0bdf67e30ed 100644
--- a/headless/app/headless_shell.cc
+++ b/headless/app/headless_shell.cc
@@ -159,6 +159,18 @@ class HeadlessShell : public HeadlessWebContents::Observer,
     // TODO(skyostil): Implement more features to demonstrate the devtools API.
   }
 
+  void RenderProcessExited(base::TerminationStatus status,
+                           int exit_code) override {
+    if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION)
+      return;
+
+    LOG(ERROR) << "Abnormal renderer termination.";
+    web_contents_->RemoveObserver(this);

[altimin, 2016/11/18 14:36:45]

Looks like we do not detail devtools observers here (see
HeadlessShell::Shutdown). Maybe we should be able to leverage
HeadlessShell::Shutdown here?

[alex clarke (OOO till 29th), 2016/11/18 14:59:38]

I had to figure out why it was crashing. That's (mostly) fixed, thers's some
other crash with no call stack in the browser shutdown.

../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.261:
    error: attempt to increment a singular iterator.

+    web_contents_ = nullptr;
+    browser_context_->Close();
+    browser_->Shutdown();
+  }
+
   void PollReadyState() {
     // We need to check the current location in addition to the ready state to
     // be sure the expected page is ready.