HeadlessWebContents:Observer to observe render process exit status

headless/app/headless_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iostream>
 #include <memory>
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 141 matching lines @@
               .SetPolicy(emulation::VirtualTimePolicy::
                              PAUSE_IF_NETWORK_FETCHES_PENDING)
               .SetBudget(budget_ms)
               .Build());
     } else {
       PollReadyState();
     }
     // TODO(skyostil): Implement more features to demonstrate the devtools API.
   }
 
+  void RenderProcessExited(base::TerminationStatus status,
+                           int exit_code) override {
+    if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION)
+      return;
+
+    LOG(ERROR) << "Abnormal renderer termination.";
+    web_contents_->RemoveObserver(this);

[altimin, 2016/11/18 14:36:45]

Looks like we do not detail devtools observers here (see
HeadlessShell::Shutdown). Maybe we should be able to leverage
HeadlessShell::Shutdown here?

[alex clarke (OOO till 29th), 2016/11/18 14:59:38]

I had to figure out why it was crashing. That's (mostly) fixed, thers's some
other crash with no call stack in the browser shutdown.

../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.261:
    error: attempt to increment a singular iterator.

+    web_contents_ = nullptr;
+    browser_context_->Close();
+    browser_->Shutdown();
+  }
+
   void PollReadyState() {
     // We need to check the current location in addition to the ready state to
     // be sure the expected page is ready.
     devtools_client_->GetRuntime()->Evaluate(
         "document.readyState + ' ' + document.location.href",
         base::Bind(&HeadlessShell::OnReadyState, base::Unretained(this)));
   }
 
   void OnReadyState(std::unique_ptr<runtime::EvaluateResult> result) {
     std::string ready_state_and_url;
@@ skipping 257 matching lines @@
     }
     builder.SetWindowSize(parsed_window_size);
   }
 
   return HeadlessBrowserMain(
       builder.Build(),
       base::Bind(&HeadlessShell::OnStart, base::Unretained(&shell)));
 }
 
 }  // namespace headless