Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html

Issue 2509813004: Improve strut handling in initial column balancing pass. (Closed)
Patch Set: Rebaseline for column-rules-fixed-height. This test no longer triggers deep layout. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html
diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html b/third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html
new file mode 100644
index 0000000000000000000000000000000000000000..fa634810af8d7f2ef647386af6f7beb5d604b7c2
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<p>There should be a green square below, and no red.</p>
+<div style="columns:4; column-gap:0; width:100px; height:150px; orphans:1; widows:1; line-height:100px;">
+ <div id="parent" style="background:red;">
+ <div id="child1" style="background:green;"><br></div>
+ <div id="child2" style="background:green;">
+ <div>
+ <br>
+ <br>
+ <br>
+ </div>
+ </div>
+ </div>
+</div>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script>
+test(() => {
+ var parent = document.getElementById("parent");
+ var child1 = document.getElementById("child1");
+ var child2 = document.getElementById("child2");
+ assert_equals(parent.offsetHeight, 400);
+ assert_equals(child1.offsetHeight, 100);
+ assert_equals(child2.offsetHeight, 300);
+}, "Balance, non-auto height, unused space");
+</script>

Powered by Google App Engine
This is Rietveld 408576698