third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html - Issue 2509813004: Improve strut handling in initial column balancing pass.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-fixed-height-unused-space-nested-block.html

Issue 2509813004: Improve strut handling in initial column balancing pass. (Closed)

Patch Set: Rebaseline for column-rules-fixed-height. This test no longer triggers deep layout. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>There should be a green square below, and no red.</p>

	3 <div style="columns:4; column-gap:0; width:100px; height:150px; orphans:1; widow s:1; line-height:100px;">

	4 <div id="parent" style="background:red;">

	5 <div id="child1" style="background:green;"><br></div>

	6 <div id="child2" style="background:green;">

	7 <div>

	8 <br>

	9 <br>

	10 <br>

	11 </div>

	12 </div>

	13 </div>

	14 </div>

	15 <script src="../../resources/testharness.js"></script>

	16 <script src="../../resources/testharnessreport.js"></script>

	17 <script>

	18 test(() => {

	19 var parent = document.getElementById("parent");

	20 var child1 = document.getElementById("child1");

	21 var child2 = document.getElementById("child2");

	22 assert_equals(parent.offsetHeight, 400);

	23 assert_equals(child1.offsetHeight, 100);

	24 assert_equals(child2.offsetHeight, 300);

	25 }, "Balance, non-auto height, unused space");

	26 </script>

OLD	NEW