Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2509753006: Revert of Plumbing for login apps device policy to extensions. (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plumbing for login apps device policy to extensions. (patchset #6 id:100001 of https://codereview.chromium.org/2306143002/ ) Reason for revert: After this change, Chrome keeps crashing on the login screen (reproduced on a minnie device). Original issue's description: > Plumbing for login apps device policy to extensions. > > This CL succeeeds the CL #2150483004 > > ChromeProcessManagerDelegate: > * Enable background pages for apps in the login profile when > command-line switch --enable-login-apps is set. > > ExtensionManagement: > * Factor out common code into GetInstallListByMode from > GetForceInstallList and GetRecommendedInstallList. > * Common function UpdateForcedExtensions. > > ExtensionSystemImpl: > * Enable extensions in login profile when command-line switch > --enable-login-apps is set. > > ExternalProviderImpl: > * In CreateExternalProviders, create an ExternalPolicyLoader for login > apps in the login profile. > > ExtensionInstallListPolicyHandler: > * Common base class to parse login and force extension install lists. > > * Switch --enable-login-apps to enable login apps. > * Extension pref extensions.install.loginlist. > > BUG=576464 > > Committed: https://crrev.com/3bbfabe266cd5138393d3e87229de567d19da005 > Cr-Commit-Position: refs/heads/master@{#432917} TBR=emaxx@chromium.org,asargent@chromium.org,bartfab@chromium.org,achuith@chromium.org,antrim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576464 Committed: https://crrev.com/146e05ac852f0ded1245c8f1a039c455d1ace7d8 Cr-Commit-Position: refs/heads/master@{#433142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -193 lines) Patch
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 3 chunks +3 lines, -26 lines 0 comments Download
M chrome/browser/extensions/extension_management.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 5 chunks +38 lines, -44 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/policy_handlers.h View 2 chunks +4 lines, -31 lines 0 comments Download
M chrome/browser/extensions/policy_handlers.cc View 3 chunks +28 lines, -48 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/pref_names.h View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/pref_names.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
hashimoto
Created Revert of Plumbing for login apps device policy to extensions.
4 years, 1 month ago (2016-11-18 07:41:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753006/1
4 years, 1 month ago (2016-11-18 07:42:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 07:43:23 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 07:47:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/146e05ac852f0ded1245c8f1a039c455d1ace7d8
Cr-Commit-Position: refs/heads/master@{#433142}

Powered by Google App Engine
This is Rietveld 408576698