Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/browser/extensions/policy_handlers.cc

Issue 2509753006: Revert of Plumbing for login apps device policy to extensions. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/policy_handlers.cc
diff --git a/chrome/browser/extensions/policy_handlers.cc b/chrome/browser/extensions/policy_handlers.cc
index bcf7d518fb7bbabed80d5ee08598089ad6728237..b0963d63112f7b7dcda894d684b2b4087a90d661 100644
--- a/chrome/browser/extensions/policy_handlers.cc
+++ b/chrome/browser/extensions/policy_handlers.cc
@@ -99,43 +99,43 @@
return true;
}
-// ExtensionInstallListPolicyHandler implementation ----------------------------
-
-ExtensionInstallListPolicyHandler::ExtensionInstallListPolicyHandler(
- const char* policy_name,
- const char* pref_name)
- : policy::TypeCheckingPolicyHandler(policy_name, base::Value::TYPE_LIST),
- pref_name_(pref_name) {}
-
-ExtensionInstallListPolicyHandler::~ExtensionInstallListPolicyHandler() {}
-
-bool ExtensionInstallListPolicyHandler::CheckPolicySettings(
+// ExtensionInstallForcelistPolicyHandler implementation -----------------------
+
+ExtensionInstallForcelistPolicyHandler::ExtensionInstallForcelistPolicyHandler()
+ : policy::TypeCheckingPolicyHandler(policy::key::kExtensionInstallForcelist,
+ base::Value::TYPE_LIST) {}
+
+ExtensionInstallForcelistPolicyHandler::
+ ~ExtensionInstallForcelistPolicyHandler() {}
+
+bool ExtensionInstallForcelistPolicyHandler::CheckPolicySettings(
const policy::PolicyMap& policies,
policy::PolicyErrorMap* errors) {
const base::Value* value;
return CheckAndGetValue(policies, errors, &value) &&
- ParseList(value, nullptr, errors);
-}
-
-void ExtensionInstallListPolicyHandler::ApplyPolicySettings(
+ ParseList(value, NULL, errors);
+}
+
+void ExtensionInstallForcelistPolicyHandler::ApplyPolicySettings(
const policy::PolicyMap& policies,
PrefValueMap* prefs) {
- const base::Value* value = nullptr;
+ const base::Value* value = NULL;
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- if (CheckAndGetValue(policies, nullptr, &value) && value &&
- ParseList(value, dict.get(), nullptr)) {
- prefs->SetValue(pref_name(), std::move(dict));
- }
-}
-
-bool ExtensionInstallListPolicyHandler::ParseList(
+ if (CheckAndGetValue(policies, NULL, &value) &&
+ value &&
+ ParseList(value, dict.get(), NULL)) {
+ prefs->SetValue(pref_names::kInstallForceList, std::move(dict));
+ }
+}
+
+bool ExtensionInstallForcelistPolicyHandler::ParseList(
const base::Value* policy_value,
base::DictionaryValue* extension_dict,
policy::PolicyErrorMap* errors) {
if (!policy_value)
return true;
- const base::ListValue* policy_list_value = nullptr;
+ const base::ListValue* policy_list_value = NULL;
if (!policy_value->GetAsList(&policy_list_value)) {
// This should have been caught in CheckPolicySettings.
NOTREACHED();
@@ -167,8 +167,8 @@
continue;
}
- const std::string extension_id = entry_string.substr(0, pos);
- const std::string update_url = entry_string.substr(pos + 1);
+ std::string extension_id = entry_string.substr(0, pos);
+ std::string update_url = entry_string.substr(pos+1);
if (!crx_file::id_util::IdIsValid(extension_id) ||
!GURL(update_url).is_valid()) {
if (errors) {
@@ -180,33 +180,13 @@
}
if (extension_dict) {
- ExternalPolicyLoader::AddExtension(extension_dict, extension_id,
- update_url);
+ extensions::ExternalPolicyLoader::AddExtension(
+ extension_dict, extension_id, update_url);
}
}
return true;
}
-
-// ExtensionInstallForcelistPolicyHandler implementation -----------------------
-
-ExtensionInstallForcelistPolicyHandler::ExtensionInstallForcelistPolicyHandler()
- : ExtensionInstallListPolicyHandler(policy::key::kExtensionInstallForcelist,
- pref_names::kInstallForceList) {}
-
-ExtensionInstallForcelistPolicyHandler::
- ~ExtensionInstallForcelistPolicyHandler() {}
-
-// ExtensionInstallSigninlistPolicyHandler implementation
-// -----------------------
-
-ExtensionInstallSigninListPolicyHandler::
- ExtensionInstallSigninListPolicyHandler()
- : ExtensionInstallListPolicyHandler(policy::key::kLoginApps,
- pref_names::kInstallSigninList) {}
-
-ExtensionInstallSigninListPolicyHandler::
- ~ExtensionInstallSigninListPolicyHandler() {}
// ExtensionURLPatternListPolicyHandler implementation -------------------------
« no previous file with comments | « chrome/browser/extensions/policy_handlers.h ('k') | chrome/browser/policy/configuration_policy_handler_list_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698