Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2509733005: MacViews: Enable some accelerator tests.

Created:
4 years, 1 month ago by tapted
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Enable some accelerator tests. MacViews: Fix accelerator handling while Omnibox is in focus. Currently in both Cocoa and MacViewsBrowser when Omnibox is in focus the accelerators are only handled in -[NativeWidgetMacNSWindow performKeyEquivalent:], which internally uses ChromeCommandDispatcherDelegate, which consults global_keyboard_shortcuts_cocoa_mac.mm's tables. In crbug.com/620315 we're trying to migrate the global_keyboard_shortcuts_cocoa_mac.mm's tables over to accelerator_table.cc. BUG=665823 patch from issue 2505943002 at patchset 1 (http://crrev.com/2505943002#ps1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -78 lines) Patch
M ui/views/cocoa/bridged_content_view.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 2 chunks +46 lines, -3 lines 0 comments Download
M ui/views/view_unittest.cc View 4 chunks +60 lines, -75 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-17 05:38:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509733005/1
4 years, 1 month ago (2016-11-17 05:39:36 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-17 05:57:39 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 05:57:40 UTC) #4
Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698