Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2509723003:
Make UpdaterStateTest.Serialize pass on Chrome-branded builds (Closed)
DescriptionMake UpdaterStateTest.Serialize pass on Chrome-branded builds
BUG=665951
Committed: https://crrev.com/c643082c26a563c5983e5a34004471978d59b57b
Cr-Commit-Position: refs/heads/master@{#432641}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (6 generated)
hans@chromium.org changed reviewers: + sorin@chromium.org, waffles@chromium.org
Please take a look. https://codereview.chromium.org/2509723003/diff/1/components/update_client/up... File components/update_client/updater_state_unittest.cc (left): https://codereview.chromium.org/2509723003/diff/1/components/update_client/up... components/update_client/updater_state_unittest.cc:49: EXPECT_STREQ("Omaha", attributes.at("name").c_str()); We just checked above (line 36) that this returns "the updater", so this test would always fail.
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Thank you for fixing this. The offending CL was tried on the default bots that git cl try kicks off. Where on the waterfall can I see the bots that are broken at the moment? Thank you!
lgtm Thank you for fixing this. The offending CL was tried on the default bots that git cl try kicks off. Where on the waterfall can I see the bots that are broken at the moment? Thank you!
On 2016/11/16 21:12:25, Sorin Jianu wrote: > lgtm > > Thank you for fixing this. The offending CL was tried on the default bots that > git cl try kicks off. Where on the waterfall can I see the bots that are broken > at the moment? I was looking at this one: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester I don't know if we have any bots running components_unittests with Chrome branding on the main waterfall, which means this kind test doesn't get much coverage and often fail.
The CQ bit was unchecked by hans@chromium.org
The CQ bit was checked by hans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Right, but how did you find that bot to start with? Even when I am looking at https://build.chromium.org/p/chromium.fyi/console I can't see anything broken due to this change. I am trying to learn how to look for this kind of things.
Right, but how did you find that bot to start with? Even when I am looking at https://build.chromium.org/p/chromium.fyi/console I can't see anything broken due to this change. I am trying to learn how to look for this kind of things.
On 2016/11/16 21:21:25, Sorin Jianu wrote: > Right, but how did you find that bot to start with? Even when I am looking at > https://build.chromium.org/p/chromium.fyi/console I can't see anything broken > due to this change. I work on Clang for Windows, and our team maintains those bots, so we keep an eye on them. > I am trying to learn how to look for this kind of things. This kind of breakage, where normal builds work but only the official ones don't is very rare. I wouldn't worry about it too much.
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make UpdaterStateTest.Serialize pass on Chrome-branded builds BUG=665951 ========== to ========== Make UpdaterStateTest.Serialize pass on Chrome-branded builds BUG=665951 Committed: https://crrev.com/c643082c26a563c5983e5a34004471978d59b57b Cr-Commit-Position: refs/heads/master@{#432641} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c643082c26a563c5983e5a34004471978d59b57b Cr-Commit-Position: refs/heads/master@{#432641} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
