Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/update_client/updater_state_unittest.cc

Issue 2509723003: Make UpdaterStateTest.Serialize pass on Chrome-branded builds (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/updater_state_unittest.cc
diff --git a/components/update_client/updater_state_unittest.cc b/components/update_client/updater_state_unittest.cc
index 74828596c8d0b10453c97ec8ce29edc07c97e498..7627b46a22d8ba8ab8cdcbc94e68d0dad9653059 100644
--- a/components/update_client/updater_state_unittest.cc
+++ b/components/update_client/updater_state_unittest.cc
@@ -41,14 +41,14 @@ TEST_F(UpdaterStateTest, Serialize) {
EXPECT_STREQ("1", attributes.at("autoupdatecheckenabled").c_str());
EXPECT_STREQ("1", attributes.at("updatepolicy").c_str());
- // Tests some of the remaining values.
- updater_state = UpdaterState(false);
-
#if defined(GOOGLE_CHROME_BUILD)
// The name of the Windows updater for Chrome.
- EXPECT_STREQ("Omaha", attributes.at("name").c_str());
hans 2016/11/16 20:39:06 We just checked above (line 36) that this returns
+ EXPECT_STREQ("Omaha", UpdaterState::GetState(false)->at("name").c_str());
#endif // GOOGLE_CHROME_BUILD
+ // Tests some of the remaining values.
+ updater_state = UpdaterState(false);
+
// Don't serialize an invalid version if it could not be read.
updater_state.updater_version_ = base::Version();
attributes = updater_state.BuildAttributes();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698