third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp b/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

index 789b76f46ea8e8bdf70a1f8c89902821f57a9189..49b660fbc1659e334d94936ab5defab68417afc0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

@@ -63,7 +63,10 @@ bool ArrayValue::get(size_t index, Dictionary& value) const {

!indexedValue->IsObject())

return false;

- value = Dictionary(m_isolate, indexedValue);

+ // TODO(bashi,yukishiino): Should rethrow the exception.

+ // http://crbug.com/666661

+ TrackExceptionState exceptionState;

+ value = Dictionary(m_isolate, indexedValue, exceptionState);

return true;

}