third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/Dictionary.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 return false;	56 return false;

57	57

58 DCHECK(m_isolate);	58 DCHECK(m_isolate);

59 DCHECK_EQ(m_isolate, v8::Isolate::GetCurrent());	59 DCHECK_EQ(m_isolate, v8::Isolate::GetCurrent());

60 v8::Local<v8::Value> indexedValue;	60 v8::Local<v8::Value> indexedValue;

61 if (!m_array->Get(m_isolate->GetCurrentContext(), index)	61 if (!m_array->Get(m_isolate->GetCurrentContext(), index)

62 .ToLocal(&indexedValue) \|\|	62 .ToLocal(&indexedValue) \|\|

63 !indexedValue->IsObject())	63 !indexedValue->IsObject())

64 return false;	64 return false;

65	65

66 value = Dictionary(m_isolate, indexedValue);	66 // TODO(bashi,yukishiino): Should rethrow the exception.

	67 // http://crbug.com/666661

	68 TrackExceptionState exceptionState;

	69 value = Dictionary(m_isolate, indexedValue, exceptionState);

67 return true;	70 return true;

68 }	71 }

69	72

70 } // namespace blink	73 } // namespace blink

OLD	NEW