Revert of added support for push_constant layout

Revert of added support for push_constant layout (patchset #7 id:140001 of https://codereview.chromium.org/2187433003/ )

Reason for revert:
hitting assert in vulkan

Original issue's description:
> added support for push_constant layout
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003
> 
> Committed: https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d

TBR=ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/988283c89458442f65d961f2746a9f271a39c31e

[egdaniel, 2016-11-16 14:02:40]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-11-16 14:02:40]

Created Revert of added support for push_constant layout

[commit-bot: I haz the power, 2016-11-16 14:02:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 14:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 14:02:59]

Failed to apply patch for src/sksl/SkSLParser.cpp:
While running git apply --index -p1;
  <stdin>:11: trailing whitespace.
  /* LAYOUT LPAREN IDENTIFIER EQ INT_LITERAL (COMMA IDENTIFIER EQ INT_LITERAL)* 
  error: patch failed: src/sksl/SkSLParser.cpp:536
  error: src/sksl/SkSLParser.cpp: patch does not apply

Patch:       src/sksl/SkSLParser.cpp
Index: src/sksl/SkSLParser.cpp
diff --git a/src/sksl/SkSLParser.cpp b/src/sksl/SkSLParser.cpp
index
154989fe84d6c5fbbb388f75c0248d52d0d4b24b..324bd41c86c972f39e9ad3714ef4069c90d8c6dd
100644
--- a/src/sksl/SkSLParser.cpp
+++ b/src/sksl/SkSLParser.cpp
@@ -526,7 +526,8 @@
     return -1;
 }
 
-/* LAYOUT LPAREN IDENTIFIER (EQ INT_LITERAL)? (COMMA IDENTIFIER (EQ
INT_LITERAL)?)* RPAREN */
+/* LAYOUT LPAREN IDENTIFIER EQ INT_LITERAL (COMMA IDENTIFIER EQ INT_LITERAL)* 
+   RPAREN */
 ASTLayout Parser::layout() {
     int location = -1;
     int binding = -1;
@@ -536,12 +537,11 @@
     bool originUpperLeft = false;
     bool overrideCoverage = false;
     bool blendSupportAllEquations = false;
-    bool pushConstant = false;
     if (this->peek().fKind == Token::LAYOUT) {
         this->nextToken();
         if (!this->expect(Token::LPAREN, "'('")) {
             return ASTLayout(location, binding, index, set, builtin,
originUpperLeft,
-                             overrideCoverage, blendSupportAllEquations,
pushConstant);
+                             overrideCoverage, blendSupportAllEquations);
         }
         for (;;) {
             Token t = this->nextToken();
@@ -561,8 +561,6 @@
                 overrideCoverage = true;
             } else if (t.fText == "blend_support_all_equations") {
                 blendSupportAllEquations = true;
-            } else if (t.fText == "push_constant") {
-                pushConstant = true;
             } else {
                 this->error(t.fPosition, ("'" + t.fText + 
                                           "' is not a valid layout
qualifier").c_str());
@@ -577,7 +575,7 @@
         }
     }
     return ASTLayout(location, binding, index, set, builtin, originUpperLeft,
overrideCoverage,
-                     blendSupportAllEquations, pushConstant);
+                     blendSupportAllEquations);
 }
 
 /* layout? (UNIFORM | CONST | IN | OUT | INOUT | LOWP | MEDIUMP | HIGHP | FLAT
| NOPERSPECTIVE)* */

[egdaniel, 2016-11-16 15:29:43]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-11-16 15:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:29:53]

Description was changed from

==========
Revert of added support for push_constant layout (patchset #7 id:140001 of
https://codereview.chromium.org/2187433003/ )

Reason for revert:
hitting assert in vulkan

Original issue's description:
> added support for push_constant layout
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003
> 
> Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d

TBR=ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
==========

to

==========
Revert of added support for push_constant layout (patchset #7 id:140001 of
https://codereview.chromium.org/2187433003/ )

Reason for revert:
hitting assert in vulkan

Original issue's description:
> added support for push_constant layout
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003
> 
> Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d

TBR=ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/988283c89458442f65d961f2746a9f271a39c31e
==========

[commit-bot: I haz the power, 2016-11-16 15:29:54]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/988283c89458442f65d961f2746a9f271a39c31e