Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2509323005: No need to force relayout of children when page logical height changes. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need to force relayout of children when page logical height changes. Also removed an ignored out-parameter hasSpecifiedPageLogicalHeight from checkForPaginationLogicalHeightChange(). Committed: https://crrev.com/0c51c4e0b63bf7213d2602a89121cecaa88ee7c2 Cr-Commit-Position: refs/heads/master@{#434290}

Patch Set 1 #

Patch Set 2 : Rebaseline invalidation tests that lay out less than before (but still pass). #

Messages

Total messages: 23 (13 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-18 14:20:30 UTC) #6
mstensho (USE GERRIT)
ping?
4 years, 1 month ago (2016-11-23 06:30:42 UTC) #7
szager1
lgtm
4 years ago (2016-11-23 16:14:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509323005/1
4 years ago (2016-11-23 16:25:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/73564)
4 years ago (2016-11-23 17:06:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509323005/1
4 years ago (2016-11-23 17:22:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/337731)
4 years ago (2016-11-23 18:00:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509323005/20001
4 years ago (2016-11-23 20:45:00 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 23:59:52 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-24 00:03:37 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c51c4e0b63bf7213d2602a89121cecaa88ee7c2
Cr-Commit-Position: refs/heads/master@{#434290}

Powered by Google App Engine
This is Rietveld 408576698