third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2509323005: No need to force relayout of children when page logical height changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2509323005: No need to force relayout of children when page logical height changes. (Closed)

Patch Set: Rebaseline invalidation tests that lay out less than before (but still pass). Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index a41c9efffef0359b6298640d1917e4b8036d8652..ea7284203edcff2250452a75ee84c22840d5b20f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -590,10 +590,7 @@ class CORE_EXPORT LayoutBlockFlow : public LayoutBlock {

LayoutUnit& totalLogicalWidth,

LayoutUnit& availableLogicalWidth,

unsigned expansionOpportunityCount);

- void checkForPaginationLogicalHeightChange(

- LayoutUnit& pageLogicalHeight,

- bool& pageLogicalHeightChanged,

- bool& hasSpecifiedPageLogicalHeight);

+ void checkForPaginationLogicalHeightChange(LayoutUnit& pageLogicalHeight);

bool shouldBreakAtLineToAvoidWidow() const {

return m_rareData && m_rareData->m_lineBreakToAvoidWidow >= 0;