[wasm] Implement frame printing for debug

[wasm] Implement frame printing for debug

This makes wasm frames show up nicely in stack traces generated e.g. by
Isolate::PrintStack() and Isolate::PrintCurrentStackTrace().
With this CL, we print the script name, function index, function name,
pc and source position.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/18084f17bbda4a3489d7c5bceeed97dcdbcb208c
Cr-Commit-Position: refs/heads/master@{#41102}

[Clemens Hammacher, 2016-11-17 16:18:12]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:21:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Clemens Hammacher, 2016-11-17 16:23:34]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-17 16:24:22]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-17 16:25:27]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Clemens Hammacher, 2016-11-17 16:26:01]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:26:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:32:54]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/17969)

[Clemens Hammacher, 2016-11-17 16:34:36]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:34:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:25:32]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-18 10:38:21]

lgtm with nit

https://codereview.chromium.org/2509323002/diff/60001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/2509323002/diff/60001/src/frames.cc#newcode1509
src/frames.cc:1509: accumulator->Add("], function #%u ('%s'), pc=%p, pos=%d\n",
Does the accumulator pass the format string to printf underneath? If so, then
you should be able to do a %.*s and not have to make a copy of the raw_func_name
contents above.

[Clemens Hammacher, 2016-11-18 12:01:28]

https://codereview.chromium.org/2509323002/diff/60001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/2509323002/diff/60001/src/frames.cc#newcode1509
src/frames.cc:1509: accumulator->Add("], function #%u ('%s'), pc=%p, pos=%d\n",
On 2016/11/18 at 10:38:21, titzer wrote:
> Does the accumulator pass the format string to printf underneath? If so, then
you should be able to do a %.*s and not have to make a copy of the raw_func_name
contents above.

No, unfortunately not. It does the formatting internally, which allows to also
handle Object* and Handle<Object>* properly.

[Clemens Hammacher, 2016-11-18 12:15:58]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-11-18 12:16:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 12:18:02]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-18 12:18:24]

Description was changed from

==========
[wasm] Implement frame printing for debug

This makes wasm frames show up nicely in stack traces generated e.g. by
Isolate::PrintStack() and Isolate::PrintCurrentStackTrace().
With this CL, we print the script name, function index, function name,
pc and source position.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
[wasm] Implement frame printing for debug

This makes wasm frames show up nicely in stack traces generated e.g. by
Isolate::PrintStack() and Isolate::PrintCurrentStackTrace().
With this CL, we print the script name, function index, function name,
pc and source position.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/18084f17bbda4a3489d7c5bceeed97dcdbcb208c
Cr-Commit-Position: refs/heads/master@{#41102}
==========

[commit-bot: I haz the power, 2016-11-18 12:18:25]

Patchset 3 (id:??) landed as
https://crrev.com/18084f17bbda4a3489d7c5bceeed97dcdbcb208c
Cr-Commit-Position: refs/heads/master@{#41102}