Unify the three CFWL_EventType::SelectChange classes.

xfa/fwl/core/ifwl_listbox.cpp

Index: xfa/fwl/core/ifwl_listbox.cpp
diff --git a/xfa/fwl/core/ifwl_listbox.cpp b/xfa/fwl/core/ifwl_listbox.cpp
index 4a8f9395b6f3388ed81c1c453d519370ad4a1fee..f1ee2f524598734e0a1a4433dfc32819d99a7052 100644
--- a/xfa/fwl/core/ifwl_listbox.cpp
+++ b/xfa/fwl/core/ifwl_listbox.cpp
@@ -843,20 +843,6 @@ bool IFWL_ListBox::IsShowScrollBar(bool bVert) {
          (m_pProperties->m_dwStates & FWL_WGTSTATE_Focused);
 }
 
-void IFWL_ListBox::ProcessSelChanged() {
-  CFWL_EvtLtbSelChanged selEvent;
-  selEvent.m_pSrcTarget = this;
-  CFX_Int32Array arrSels;
-  int32_t iCount = CountSelItems();
-  for (int32_t i = 0; i < iCount; i++) {
-    CFWL_ListItem* item = GetSelItem(i);
-    if (!item)
-      continue;
-    selEvent.iarraySels.Add(i);
-  }
-  DispatchEvent(&selEvent);

[npm, 2016/11/17 18:39:07]

I agree with deletion of unused m_pSrcTarget and iarraySels. But we are also
assuming that DispatchEvent does nothing if it does not know the event it
receives, right? Just making sure this is right :)

[dsinclair, 2016/11/17 18:39:54]

All the ones I've seen check the EventType before doing any processing.

[npm, 2016/11/17 18:45:07]

I think there is only one implementation of DispatchEvent.

-}
-
 void IFWL_ListBox::OnProcessMessage(CFWL_Message* pMessage) {
   if (!pMessage)
     return;
@@ -974,7 +960,6 @@ void IFWL_ListBox::OnLButtonDown(CFWL_MsgMouse* pMsg) {
   SetFocusItem(pItem);
   ScrollToVisible(pItem);
   SetGrab(true);
-  ProcessSelChanged();
   Repaint(&m_rtClient);
 }
 
@@ -984,7 +969,6 @@ void IFWL_ListBox::OnLButtonUp(CFWL_MsgMouse* pMsg) {
 
   m_bLButtonDown = false;
   SetGrab(false);
-  DispatchSelChangedEv();
 }
 
 void IFWL_ListBox::OnMouseWheel(CFWL_MsgMouseWheel* pMsg) {
@@ -1005,8 +989,6 @@ void IFWL_ListBox::OnKeyDown(CFWL_MsgKey* pMsg) {
       bool bShift = !!(pMsg->m_dwFlags & FWL_KEYFLAG_Shift);
       bool bCtrl = !!(pMsg->m_dwFlags & FWL_KEYFLAG_Ctrl);
       OnVK(pItem, bShift, bCtrl);
-      DispatchSelChangedEv();
-      ProcessSelChanged();
       break;
     }
     default:
@@ -1097,9 +1079,3 @@ bool IFWL_ListBox::OnScroll(IFWL_ScrollBar* pScrollBar,
   }
   return true;
 }
-
-void IFWL_ListBox::DispatchSelChangedEv() {
-  CFWL_EvtLtbSelChanged ev;
-  ev.m_pSrcTarget = this;
-  DispatchEvent(&ev);
-}