Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: xfa/fwl/core/ifwl_listbox.cpp

Issue 2509283003: Unify the three CFWL_EventType::SelectChange classes. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/core/ifwl_listbox.cpp
diff --git a/xfa/fwl/core/ifwl_listbox.cpp b/xfa/fwl/core/ifwl_listbox.cpp
index 4a8f9395b6f3388ed81c1c453d519370ad4a1fee..503f67a5b03071052cabd2282e277f0662b060dd 100644
--- a/xfa/fwl/core/ifwl_listbox.cpp
+++ b/xfa/fwl/core/ifwl_listbox.cpp
@@ -843,19 +843,7 @@ bool IFWL_ListBox::IsShowScrollBar(bool bVert) {
(m_pProperties->m_dwStates & FWL_WGTSTATE_Focused);
}
-void IFWL_ListBox::ProcessSelChanged() {
npm 2016/11/17 18:07:02 Can we delete this method altogether?
dsinclair 2016/11/17 18:13:19 Done.
- CFWL_EvtLtbSelChanged selEvent;
- selEvent.m_pSrcTarget = this;
- CFX_Int32Array arrSels;
- int32_t iCount = CountSelItems();
- for (int32_t i = 0; i < iCount; i++) {
- CFWL_ListItem* item = GetSelItem(i);
- if (!item)
- continue;
- selEvent.iarraySels.Add(i);
- }
- DispatchEvent(&selEvent);
-}
+void IFWL_ListBox::ProcessSelChanged() {}
void IFWL_ListBox::OnProcessMessage(CFWL_Message* pMessage) {
if (!pMessage)
@@ -1098,8 +1086,4 @@ bool IFWL_ListBox::OnScroll(IFWL_ScrollBar* pScrollBar,
return true;
}
-void IFWL_ListBox::DispatchSelChangedEv() {
npm 2016/11/17 18:07:02 Ditto
dsinclair 2016/11/17 18:13:19 Done.
- CFWL_EvtLtbSelChanged ev;
- ev.m_pSrcTarget = this;
- DispatchEvent(&ev);
-}
+void IFWL_ListBox::DispatchSelChangedEv() {}

Powered by Google App Engine
This is Rietveld 408576698