Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2509233003:
Use GCC/Clang builtins for Checked(Add|Sub|Mul) (Closed)
DescriptionUse GCC/Clang builtins for Checked(Add|Sub|Mul)
BUG=613003
Committed: https://crrev.com/990079ab09e7785132dfdd3021c748c878c9a551
Cr-Commit-Position: refs/heads/master@{#433184}
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : clang compile fix #Patch Set 4 : clang compile fix (really) #Patch Set 5 : clang compile fix (last time) #Messages
Total messages: 25 (14 generated)
Patchset #2 (id:20001) has been deleted
Patchset #4 (id:80001) has been deleted
Patchset #4 (id:100001) has been deleted
Patchset #5 (id:140001) has been deleted
jschuh@chromium.org changed reviewers: + tsepez@chromium.org
ptal
lgtm
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by jschuh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org Link to the patchset: https://codereview.chromium.org/2509233003/#ps160001 (title: "clang compile fix (last time)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Use GCC/Clang builtins for Checked(Add|Sub|Mul) BUG=613003 ========== to ========== Use GCC/Clang builtins for Checked(Add|Sub|Mul) BUG=613003 Committed: https://crrev.com/990079ab09e7785132dfdd3021c748c878c9a551 Cr-Commit-Position: refs/heads/master@{#433184} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/990079ab09e7785132dfdd3021c748c878c9a551 Cr-Commit-Position: refs/heads/master@{#433184} |
