Fix Aura build when toolkit_views==0

Fix Aura build when toolkit_views==0

This fixes Aura builds (such as Ozone) which compile with use_aura=1 and
toolkit_views=0.

TBR=ben@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266641

[dnicoara, 2014-04-28 15:39:47]

PTAL

ben@ for OWNERS
tapted@ FYI

This is related to https://codereview.chromium.org/248893002 which removed this
support.

[dnicoara, 2014-04-28 19:42:32]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:43:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dnicoara@chromium.org/250923014/10001

[commit-bot: I haz the power, 2014-04-28 20:01:47]

Change committed as 266641

[tapted, 2014-04-28 23:57:23]

Sorry about that! Please see comment below.

https://codereview.chromium.org/250923014/diff/10001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/250923014/diff/10001/ui/gfx/gfx.gyp#newcode351
ui/gfx/gfx.gyp:351: ['use_aura==0', {
Sadly this breaks use_aura=0, toolkit_views=1. I think it just needs to match
the condition at ui_base.gyp:392

i.e. 'toolkit_views==0 and use_aura==0'

That works for views on mac. Is there an ozone bot I can test with? (for this
and future stuff :). I tried linux_ecs_ozone a while ago and it seems a bit
random.

I have a bug on me for a better gyp file cleanup at http://crbug.com/351951 .
First attempt failed so I'm trimming some stray threads first.

[dnicoara, 2014-04-29 00:43:27]

On 2014/04/28 23:57:23, tapted wrote:
> Sorry about that! Please see comment below.
> 
> https://codereview.chromium.org/250923014/diff/10001/ui/gfx/gfx.gyp
> File ui/gfx/gfx.gyp (right):
> 
> https://codereview.chromium.org/250923014/diff/10001/ui/gfx/gfx.gyp#newcode351
> ui/gfx/gfx.gyp:351: ['use_aura==0', {
> Sadly this breaks use_aura=0, toolkit_views=1. I think it just needs to match
> the condition at ui_base.gyp:392
> 
> i.e. 'toolkit_views==0 and use_aura==0'
> 
> That works for views on mac. Is there an ozone bot I can test with? (for this
> and future stuff :). I tried linux_ecs_ozone a while ago and it seems a bit
> random.
> 
> I have a bug on me for a better gyp file cleanup at http://crbug.com/351951 .
> First attempt failed so I'm trimming some stray threads first.

Ah, sorry, I didn't think there was a build with toolkit_views=1 and use_aura=0.

Yes, linux_ecs_ozone is our Ozone bot. It is mostly stable (green) now days :)

[Ben Goodger (Google), 2014-04-30 03:35:29]

The app list guys are looking into using views on Mac there, where they
don't (yet) have Aura.

-Ben


On Mon, Apr 28, 2014 at 5:43 PM, <dnicoara@chromium.org> wrote:

> On 2014/04/28 23:57:23, tapted wrote:
>
>> Sorry about that! Please see comment below.
>>
>
>  https://codereview.chromium.org/250923014/diff/10001/ui/gfx/gfx.gyp
>> File ui/gfx/gfx.gyp (right):
>>
>
>  https://codereview.chromium.org/250923014/diff/10001/ui/
>> gfx/gfx.gyp#newcode351
>> ui/gfx/gfx.gyp:351: ['use_aura==0', {
>> Sadly this breaks use_aura=0, toolkit_views=1. I think it just needs to
>> match
>> the condition at ui_base.gyp:392
>>
>
>  i.e. 'toolkit_views==0 and use_aura==0'
>>
>
>  That works for views on mac. Is there an ozone bot I can test with? (for
>> this
>> and future stuff :). I tried linux_ecs_ozone a while ago and it seems a
>> bit
>> random.
>>
>
>  I have a bug on me for a better gyp file cleanup at
>> http://crbug.com/351951 .
>> First attempt failed so I'm trimming some stray threads first.
>>
>
> Ah, sorry, I didn't think there was a build with toolkit_views=1 and
> use_aura=0.
>
> Yes, linux_ecs_ozone is our Ozone bot. It is mostly stable (green) now
> days :)
>
> https://codereview.chromium.org/250923014/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.