Issue 248893002: MacViews: gyp changes for a non-aura toolkit views on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248893002: MacViews: gyp changes for a non-aura toolkit views on mac (Closed)

Created:
6 years, 8 months ago by tapted

Modified:
6 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, dcheng, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

MacViews: gyp changes for a non-aura toolkit views on mac wm.gyp:wm depends on aura.gyp:aura, so this ensures that any gyp use_aura guards also guard wm.gyp. Also fix some toolkit_views/use_aura gyp usage, and add mac stubs for ui/base/dragdrop so the gyp conditions don't explode (they will be needed later). BUG=366007 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266283

Patch Set 1 #

Patch Set 2 : rebase for r265571 conflict, less similarity #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -39 lines)			Patch
M	chrome/chrome_browser_ui.gypi	View	1	4 chunks	+9 lines, -14 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/app_list/app_list.gyp	View		2 chunks	+1 line, -1 line	0 comments	Download
A	ui/base/dragdrop/drag_utils_mac.mm	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A	ui/base/dragdrop/os_exchange_data_provider_mac.mm	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	ui/base/ui_base.gyp	View	1	6 chunks	+7 lines, -14 lines	0 comments	Download
M	ui/gfx/gfx.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/views.gyp	View	1	8 chunks	+20 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tapted

Hi Ben, it's another small slice towards compiling the views target - please take a ...

6 years, 8 months ago (2014-04-24 11:52:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/248893002/60001

6 years, 8 months ago (2014-04-25 08:24:02 UTC) #4

Message was sent while issue was closed.

Change committed as 266283

Expand Messages | Collapse Messages