Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250923008: Remove PageInfo interface. (Closed)

Created:
6 years, 8 months ago by newt (away)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, avayvod+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove PageInfo interface. BUG=367231 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -68 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/NativePage.java View 3 chunks +19 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 7 chunks +9 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 2 chunks +1 line, -18 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/PageInfo.java View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
PTAL
6 years, 8 months ago (2014-04-25 23:02:12 UTC) #1
David Trainor- moved to gerrit
lgtm
6 years, 7 months ago (2014-04-29 17:41:53 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 7 months ago (2014-04-29 20:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/250923008/1
6 years, 7 months ago (2014-04-29 20:44:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:10:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:10:56 UTC) #6
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 7 months ago (2014-04-30 01:32:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/250923008/1
6 years, 7 months ago (2014-04-30 01:34:58 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 01:38:34 UTC) #9
Message was sent while issue was closed. 
Change committed as 267033

Powered by Google App Engine
This is Rietveld 408576698