Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/NativePage.java

Issue 250923008: Remove PageInfo interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/NativePage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/NativePage.java b/chrome/android/java/src/org/chromium/chrome/browser/NativePage.java
index 7ad385040867dfb74d221de87ee82e79335677c8..ea210e73ab9684fa7fecf8777e0ce3b0d6d086af 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/NativePage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/NativePage.java
@@ -5,13 +5,22 @@
package org.chromium.chrome.browser;
import android.graphics.Bitmap;
-
-import org.chromium.content.browser.PageInfo;
+import android.view.View;
/**
* An interface for pages that will be shown in a tab using Android views instead of html.
*/
-public interface NativePage extends PageInfo {
+public interface NativePage {
+ /**
+ * @return The View to display the page. This is always non-null.
+ */
+ View getView();
+
+ /**
+ * @return The title of the page.
+ */
+ String getTitle();
+
/**
* @return The URL of the page.
*/
@@ -23,9 +32,9 @@ public interface NativePage extends PageInfo {
public String getHost();
/**
- * Called after a page has been removed from the view hierarchy and will no longer be used.
+ * @return The background color of the page.
*/
- public void destroy();
+ int getBackgroundColor();
/**
* Updates the native page based on the given url.
@@ -33,6 +42,11 @@ public interface NativePage extends PageInfo {
public void updateForUrl(String url);
/**
+ * Called after a page has been removed from the view hierarchy and will no longer be used.
+ */
+ public void destroy();
+
+ /**
* @return An unscaled screenshot of the page.
*/
Bitmap getBitmap();
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698