Correct the OffscreenCanvas.getContext API

Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/336743c75471ed1036037c0c423a78b4ad41fe3f
Cr-Commit-Position: refs/heads/master@{#433721}

[xidachen, 2016-11-17 02:13:26]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, xlai@chromium.org

[xidachen, 2016-11-17 02:13:27]

PTAL

[Justin Novosad, 2016-11-17 15:36:42]

https://codereview.chromium.org/2509193002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html
(right):

https://codereview.chromium.org/2509193002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html:20:
assert_throws(new TypeError(), function() { aCanvas.getContext('3d'); });
For readability, use a string that is more obviously wrong, like 'bogus'.

https://codereview.chromium.org/2509193002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl
(right):

https://codereview.chromium.org/2509193002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl:10:
enum OffscreenRenderingContextType { "2d", "webgl" };
please add webgl2.

Hmmm, and we need a test that verifies that getContext('webgl2') return the
right kind of context.

[xidachen, 2016-11-17 20:57:30]

Description was changed from

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

BUG=666024
==========

to

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

BUG=666024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xidachen, 2016-11-17 21:05:20]

Description was changed from

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

BUG=666024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xidachen, 2016-11-17 21:05:20]

xidachen@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[xidachen, 2016-11-17 21:06:08]

xidachen@chromium.org changed reviewers:
+ haraken@chromium.org

[xidachen, 2016-11-17 21:06:09]

+haraken@ for changes under ModulesInitializer.cpp.
+kbr@ and zmo@ for WebGL/ changes.

PTAL

[Justin Novosad, 2016-11-17 21:23:28]

lgtm

[xidachen, 2016-11-21 15:01:37]

Description was changed from

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xidachen, 2016-11-21 15:01:37]

xidachen@chromium.org changed reviewers:
- haraken@chromium.org

[xidachen, 2016-11-21 15:02:09]

TBR haraken@ for change under ModulesInitializer.cpp as it is very trivial.

kbr@, zmo@: could you please look at changes under webgl/?

[Ken Russell (switch to Gerrit), 2016-11-21 19:55:56]

lgtm

[xidachen, 2016-11-21 19:56:58]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 19:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-11-21 20:47:51]

The CQ bit was unchecked by xidachen@chromium.org

[haraken, 2016-11-22 00:04:21]

LGTM

[xidachen, 2016-11-22 00:58:07]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:06:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479776287082210,
"parent_rev": "ba6285438504b5bc90933e90da8879884637518f", "commit_rev":
"4327bba5a78e1e69c9c0e74f66afd5188e2a55a0"}

[commit-bot: I haz the power, 2016-11-22 01:07:42]

Description was changed from

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-22 01:07:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 01:11:59]

Description was changed from

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Correct the OffscreenCanvas.getContext API

Currently this API takes a DOMString as its first argument. The spec
recently changed to let it take an enum as the first argument. This CL
makes the change and adds a test case.

This CL also makes OffscreenCanvas support webgl2 context creation. To test
that, there is a github pull request here:
https://github.com/KhronosGroup/WebGL/pull/2159
Locally it works fine.

BUG=666024, 666339
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/336743c75471ed1036037c0c423a78b4ad41fe3f
Cr-Commit-Position: refs/heads/master@{#433721}
==========

[commit-bot: I haz the power, 2016-11-22 01:11:59]

Patchset 2 (id:??) landed as
https://crrev.com/336743c75471ed1036037c0c423a78b4ad41fe3f
Cr-Commit-Position: refs/heads/master@{#433721}